Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/parquet] remove Parquet exporter #27285

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Sep 30, 2023

Description:
Remove the parquet exporter

Link to tracking Issue:
Fixes #27284

@atoulme atoulme requested a review from a team September 30, 2023 18:20
@github-actions github-actions bot added cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command exporter/parquet labels Sep 30, 2023
@github-actions github-actions bot requested a review from pmcollins September 30, 2023 18:21
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we should deprecate this first before removing

@@ -1,51 +0,0 @@
module github.com/open-telemetry/opentelemetry-collector-contrib/exporter/parquetexporter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should at least deprecate the module here for one release (could be a point release as we have done previously), otherwise it will not show as deprecated on https://pkg.go.dev/github.com/open-telemetry/opentelemetry-collector-contrib/exporter/parquetexporter

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atoulme atoulme added the on hold This is blocked by another PR/issue label Oct 2, 2023
mx-psi pushed a commit that referenced this pull request Oct 3, 2023
**Description:**
Deprecate Parquet exporter before removing it altogether.

**Link to tracking Issue:**
#27285
@atoulme
Copy link
Contributor Author

atoulme commented Oct 3, 2023

This PR will wait until 0.87.0 is out.

@atoulme atoulme force-pushed the remove_parquet_exporter branch from 65cfa54 to 6a09ef1 Compare October 11, 2023 05:09
@dmitryax dmitryax merged commit e5e0aa0 into open-telemetry:main Oct 11, 2023
78 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 11, 2023
@mx-psi mx-psi removed the on hold This is blocked by another PR/issue label Oct 11, 2023
JaredTan95 pushed a commit to openinsight-proj/opentelemetry-collector-contrib that referenced this pull request Oct 18, 2023
**Description:**
Remove the parquet exporter

**Link to tracking Issue:**
Fixes open-telemetry#27284
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
**Description:**
Deprecate Parquet exporter before removing it altogether.

**Link to tracking Issue:**
open-telemetry#27285
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
**Description:**
Remove the parquet exporter

**Link to tracking Issue:**
Fixes open-telemetry#27284
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command exporter/parquet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider removing parquetexporter
4 participants